hein added a comment.
Love this (well I suggested it :) and would be a nice first for Plasma
Desktop. Code actually looks pretty good.
INLINE COMMENTS
> Task.qml:288
> +
> + /*width: (label.visible ? height
> + : parent.width - icon.adjustMargin(true, parent.width,
> taskFrame.margins.right)
?
> Task.qml:364
> + if (muted) {
> + subTextEntries.push(i18n("This application is
> currently muted."));
> + } else {
Do we need "This application" or can we simplify to "Currently muted."?
> Task.qml:588
> +
> + updateAudioStreams()
> }
Coding style: Missing trailing semicolon.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3302
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasma:_design, drosca, hein
Cc: colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas
