----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/#review100777 -----------------------------------------------------------
If I understand it correctly, the review include two separate change (import + fixes), is it correct? Then it's fine by me (pending confirmation for the shipit), the changes are fine and we can refine it later (better than the current situation). - Luigi Toscano On Nov. 11, 2016, 10:02 a.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128914/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 10:02 a.m.) > > > Review request for Documentation, Localization and Translation (l10n) and > Plasma. > > > Repository: kde-cli-tools > > > Description > ------- > > doc/kcontrol/filetypes/ splitted from kde-runtime master using > https://github.com/ajdruff/git-splits > > Not included in build so far, the docbook ismported as it was splitted > > To be done next: > adapt CMakeLists.txt, change dtd to kf5, > reapply one update done in plasma-desktop > make co-installable, see https://git.reviewboard.kde.org/r/128912/ > remove this imported kcontrol docbook from plasma-desktop > adapt scripty to these changes > > > Diffs > ----- > > doc/CMakeLists.txt 6987c14 > doc/kcontrol5/CMakeLists.txt PRE-CREATION > doc/kcontrol5/filetypes/CMakeLists.txt PRE-CREATION > doc/kcontrol5/filetypes/index.docbook PRE-CREATION > keditfiletype/filetypes.desktop 76f11cf > > Diff: https://git.reviewboard.kde.org/r/128914/diff/ > > > Testing > ------- > > history looks good, see git-log-doc-kcontrol-kio-cli-tools.output, same log > in kde-runtime master > > > File Attachments > ---------------- > > git-log-doc-kcontrol-kio-cli-tools.output > > https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/32f72127-aa97-4393-88e1-d830e35dbfe2__git-log-doc-kcontrol-kio-cli-tools.output > > > Thanks, > > Burkhard Lück > >
