broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY When a notification contains URLs, they will be shown as a large preview (in case of one thumbnail) or multiple in a strip (similar to what Klipper does). The previews can be clicked to open the file and can be dragged anywhere (e.g. to a webbrowser or chat window). TEST PLAN F555195: Screenshot_20161129_173221.png <https://phabricator.kde.org/F555195> Spectacle can take advantage of this (the cursor actually changes to the open hand cursor to indicate it's a draggable surface but this cannot be seen in the screenshot) F555196: Screenshot_20161129_173311.png <https://phabricator.kde.org/F555196> Regular image passed as argument F555197: Screenshot_20161129_173410.png <https://phabricator.kde.org/F555197> Multiple files that fit in the notification F555198: Screenshot_20161129_173431.png <https://phabricator.kde.org/F555198> Too many files, overflow F555199: Screenshot_20161129_173215.png <https://phabricator.kde.org/F555199> Single file without thumbnail - ideally it would then fall back to the small square representation but that is difficult to achieve Clicking the thumbnails currently doesn't work because the MEL eats the click away. Also, right-click does nothing - would be neat to have the regular KIO file context menu there. It also doesn't properly work with grouping, ie. when two notifications are grouped together, the thumbnail shown is the one from the last notification. Needs https://git.reviewboard.kde.org/r/129586/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3539 AFFECTED FILES applets/notifications/package/contents/ui/NotificationItem.qml applets/notifications/package/contents/ui/NotificationPopup.qml applets/notifications/plugin/CMakeLists.txt applets/notifications/plugin/notificationshelperplugin.cpp applets/notifications/plugin/thumbnailer.cpp applets/notifications/plugin/thumbnailer.h dataengines/notifications/notificationsengine.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas