mart requested changes to this revision. mart added a reviewer: mart. mart added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > DigitalClock.qml:57 > // if the date/timezone cannot be fit with the smallest font to its > designated space > - readonly property bool tooSmall: plasmoid.formFactor == > PlasmaCore.Types.Horizontal && Math.round(2 * (main.height / 5)) <= > theme.smallestFont.pixelSize > + readonly property bool tooSmall: plasmoid.formFactor == > PlasmaCore.Types.Horizontal && Math.floor(0.4 * main.height) <= > theme.smallestFont.pointSize > here you are comparing points and pixels REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
