mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> TextField.qml:49
> +    // this takes into account kiosk restriction
> +    readonly property bool __effectiveRevealPasswordButtonShown: 
> revealPasswordButtonShown
> +                                                              && 
> KAuthorized.authorize("lineedit_reveal_password")

instead of having a __ name, could also be a property of an object that's 
inside instead of the root object, so would be pretty much inaccessible from 
the outside

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3654

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Reply via email to