----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129716/ -----------------------------------------------------------
Review request for KDE Frameworks and Plasma. Repository: kpackage Description ------- When parsing the desktop files, pass together the kpackage-generic.desktop service type, so that the parser knows its intrinsic types (most especially `X-KPackage-Dependencies` which is in fact added now). This is important because otherwise we get warnings when we extract the value when the package is a desktop file. This would be much less of a problem if desktop service types could be extended, but it's not the case at the moment. Diffs ----- src/kpackage/data/servicetypes/kpackage-generic.desktop 879d3b2 src/kpackage/package.cpp c032e6e src/kpackage/private/packagejobthread.cpp 8697341 Diff: https://git.reviewboard.kde.org/r/129716/diff/ Testing ------- Managed to install llukas's example. Thanks, Aleix Pol Gonzalez