dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> iconapplet.cpp:369
> + QFile::remove(m_localPath);
> + setUrl(QUrl(desktopFile.readUrl())); // calls populate() itself
> + } else {
It looks like you're reading from a deleted file here ;) But that's not a
problem, it works since KDesktopFile (KConfig) caches everything in memory. So
it's fine, don't change it, it's just funny to read.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3906
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
