davidedmundson added inline comments. INLINE COMMENTS
> tasksmodel.cpp:388 > > + QObject::connect(filterProxyModel, &QAbstractItemModel::rowsRemoved, q, > + [this](const QModelIndex &parent, int first, int last) { I think it's a bit weird that we have a pair: groupingProxyModel::aboutToRemove filterProxyModel:rowsRemoved As it doesn't match up evenly. It'll work, but having them both the same will be less confusing long term. I think changing the first connect to filterProxyModel might result in logic being overall simpler. You'd be processing the launcher every time any window got removed, but that might fix what's in the bug reports. Other than that, the change looks good. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3950 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmundson, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas