markg requested changes to this revision. markg added a reviewer: markg. markg added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > containmentconfigview.h:56 > > + void setContainment(Plasma::Containment* containment); > + I think you forgot to remove this one? ;) For this commit that is. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4030 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, markg Cc: markg, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas