broulik added inline comments.

INLINE COMMENTS

> kdbusimporter.h:50
> +    QMenu *createMenu(QWidget *parent) override {
> +        return new VerticalMenu(parent);
> +    }

The VerticalMenu needs to be told the service name and object path of the menu, 
otherwise in hideMenu it can't emit "menuHidden(service, path)"

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4062

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, 
sebas

Reply via email to