hein requested changes to this revision. hein added a reviewer: hein. hein added a comment. This revision now requires changes to proceed.
Hmm, weird. I remember seeing that warning and changing the condition to cachedRectangleSelection && cachedRectangleSelection.length, but somehow it didn't end up in git. If you go with [] here, you also need to change line 364. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4093 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, hein Cc: hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas