broulik added inline comments. INLINE COMMENTS
> ContextMenu.qml:537 > + onClicked: { > + console.log("unpin request", modelIndex, > get(atm.LauncherUrlWithoutIcon)); > + Unrelated > GroupDialog.qml:63 > + > + console.log(itemTop, itemBottom); > + Remove > GroupDialog.qml:113-114 > > - return -1; > + width: parent.width > + height: parent.height > + Why this change? > GroupDialog.qml:119 > + // transition after setting the model so onTriggered > + // will run after the Flow has positioned items. > + FTR: Qt 5.9 will add a "positioningComplete" signal :) > GroupDialog.qml:156 > + var task = groupRepeater.itemAt(0); > + task.forceActiveFocus(); > + scrollArea.ensureItemVisible(task); Can you perhaps have the task do that automatically since fwict you always do forceActiveFocus and then ensureItemVisible: onActiveFocusChanged: { if (activeFocus) { ensureItemVisible(this); } } > GroupDialog.qml:253 > + for (var i = 0; i < taskList.children.length - 1; ++i) { > + taskList.children[i] = maxWidth; > + } ? > GroupDialog.qml:264 > + Component.onCompleted: { > + textMetrics = Qt.createQmlObject('import QtQuick 2.7; TextMetrics > {}', groupDialog); > + } Why not assign it directly above? property TextMetrics textMetrics: TextMetrics {} REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4229 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas