mart added inline comments.

INLINE COMMENTS

> apol wrote in ListItem.qml:97
> Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain...
> 
> It's barely a behavioral change, in fact it's what it was supposed to happen 
> in the first place: give feedback on hover when the item is clickable.
> Note that at the moment we're dimming the opacity for the invisible 
> background we have.

when the item contains the mouse the prefix shouldn't be "pressed"
I'm fine with using the highlight item and just dropping the opacity change

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Reply via email to