> On Jan. 27, 2017, 4:55 p.m., Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.h, line 152 > > <https://git.reviewboard.kde.org/r/129872/diff/3/?file=490020#file490020line152> > > > > why move this line?
I will fix it this mistake. > On Jan. 27, 2017, 4:55 p.m., Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, lines 245-247 > > <https://git.reviewboard.kde.org/r/129872/diff/3/?file=490021#file490021line245> > > > > this is not reading the default settings. Also theme is missing It sets HasWindowDecorationRole depend on library entry presence. Please notice line 214 KSharedConfigPtr conf = KSharedConfig::openConfig(pkg.filePath("defaults")); It reads defaults > On Jan. 27, 2017, 4:55 p.m., Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, line 363 > > <https://git.reviewboard.kde.org/r/129872/diff/3/?file=490021#file490021line363> > > > > this is reading the wrong group No, please notice line 279 KSharedConfigPtr conf = KSharedConfig::openConfig(package.filePath("defaults")); it reads defaults, i push it WindowDecoration there > On Jan. 27, 2017, 4:55 p.m., Martin Gräßlin wrote: > > kcms/lookandfeel/kcm.cpp, lines 671-675 > > <https://git.reviewboard.kde.org/r/129872/diff/3/?file=490021#file490021line671> > > > > why remove the dbus call? This is not needed at this time, it's done on line 371 - Anthony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129872/#review102285 ----------------------------------------------------------- On Jan. 24, 2017, 10 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129872/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 10 p.m.) > > > Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco > Martin. > > > Repository: plasma-desktop > > > Description > ------- > > ^^ > > > Diffs > ----- > > kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f > kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de > kcms/lookandfeel/kcm.h c27b7f3d > kcms/lookandfeel/kcm.cpp 6ea3d050 > > Diff: https://git.reviewboard.kde.org/r/129872/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
