martinkostolny created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY This is meant more as a question rather then actual code fix intention: I have a problem with `sudoedit` cmd line tool only accepting password from `ksshaskpass` if it is provided with newline in the end. Specifically in current state - calling: EDITOR=kate SUDO_ASKPASS=/usr/bin/ksshaskpass sudoedit -A /etc/hosts ...will result in a Ksshaskpass dialog and after entering the password the command just ends. But after applying this patch it starts working and kate is opened. I tried other graphical askpass programs, namely ssh-askpass, qt4-ssh-askpass, lxqt-ssh-askpass and gnome-ssh-askpass2 (gtk2). They all work nicely with sudoedit. My question is: Is it intentional that the password is not returned with newline? Should I ask sudoedit guys instead? Or is the problem elswhere, e.g. in KPasswordDialog (KF5 kwidgetaddons)? Thanks! PS: Please add reviewers as needed, I don't know the proper flow here, sorry :). TEST PLAN Tested on sudoedit as well as git connecting to github with username and password. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D4775 AFFECTED FILES src/main.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: martinkostolny, cfeck Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol