subdiff created this revision. subdiff added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY With https://phabricator.kde.org/D4867 the placement was already changed a bit, but mostly the correction if there is not enough screen space available. This new patch is meant to harmonize the placement for the available enums in a sensible way. Instead of much talking take a look at the placement **prior** to https://phabricator.kde.org/D4867: F2676516: plan1.png <https://phabricator.kde.org/F2676516> Currently / with https://phabricator.kde.org/D4867: F2676517: plan2.png <https://phabricator.kde.org/F2676517> With this patch: F2676518: plan3.png <https://phabricator.kde.org/F2676518> Regarding the enum names in the API and the normal use cases of a menu I think this last pattern makes the most sense. In this case the correctional behavior on screen space limits could get simplified as well. This would become a separate patch though. TEST PLAN Tested with plasma-pa and task manager context menu. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4921 AFFECTED FILES src/declarativeimports/plasmacomponents/qmenu.cpp To: subdiff, #plasma Cc: #frameworks, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
