rjvbb added inline comments.

INLINE COMMENTS

> kfunk wrote in backtracegenerator.h:87
> Looks pretty unclean to have a backend-specific variable around here.

I missed this one. I don't think it's possible to detect detaching (from the 
debugger output!) elsewhere but in the bt. generator. Not without adding a line 
parser to the backend.

That *would* be the proper way to proceed if other backends required detecting 
a detached debugger too, but apparently that isn't the case.

REVISION DETAIL
  https://phabricator.kde.org/D4929

To: rjvbb, #plasma_workspaces, kfunk
Cc: kfunk, mart, broulik, kde-mac, plasma-devel, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to