dfaure added a comment.
The idea sounds OK to me. INLINE COMMENTS > CMakeLists.txt:32 > + FILE KF5KioArchiveTargets.cmake > + NAMESPACE KF5:: > +) The KF5 prefix is wrong, this isn't part of KF5. > CMakeLists.txt:44 > + > +add_library(KF5KioArchive kio_archivebase.cpp kio_archive_debug.cpp) > + The KF5 prefix is wrong, this isn't part of KF5. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D5112 To: marten, #plasma, dfaure Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
