graesslin added a comment.
In https://phabricator.kde.org/D5405#101626, @ltoscano wrote: > In https://phabricator.kde.org/D5405#101624, @graesslin wrote: > > > In https://phabricator.kde.org/D5405#101621, @ltoscano wrote: > > > > > In https://phabricator.kde.org/D5405#101615, @graesslin wrote: > > > > > > > The desktop file name should follow the way how the dbus name is created. If the applications are broken, then they are broken. Given that I mentioned this several times at KDE conferences, blogged about it, sent mails to KDE devel lists I assume the application maintainers don't care whether their applications work on Wayland. Which is totally fine. Then let them stay broken. > > > > > > > > > When you talk about "desktop file name", do you mean the method desktopFileName() in KAboutData, or the real file name of the desktop file? > > > > > > Here I meant the method in Kaboutdata. > > > > > Also: I did not maintain an application back then and I missed those notifications. Could you please link at least one reference to the explanation (or which Akademy)? I will get the others from that. > > > > https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/ > > > Thanks. I guess it's the section "Setting window icon", but: > > - there are no references to D-Bus, which you referred to in the previous comment (not also in the rest of the page in this context); Yes. I didn't want to imply that it must be the same as dbus. I think our code should apply the same logic to generate dbus name and desktop file name. > - the "domain name" link refers to organizationDomain. The problem here is that the icon was not visible in applications were organizationDomain was properly set, because the homepage was used when setting the desktop file name. It might be that this used to work back then or that I was not aware of the problem. > So setDesktopFileName must be used explicitly, and maybe it was not available when you wrote the blog post, could you please add a note there to reference that method? Yes I added setDesktopFileName after that blog post. I normally do not modify old blog posts as they should not be our documentation. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D5405 To: stikonas, mpyne, kossebau, aacid, ltoscano Cc: nalvarez, graesslin, mak, plasma-devel, kde-frameworks-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol
