----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130094/#review103072 -----------------------------------------------------------
src/platformtheme/kdeplatformtheme.cpp (line 421) <https://git.reviewboard.kde.org/r/130094/#comment68568> foreach OR for (... : qAsConst(m_standardPathItems)) Or use std::vector and keep the for as is.. qAsConst is in Qt since 5.7 so i think that's a bit to new to use. - Mark Gaiser On apr 21, 2017, 8:04 a.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130094/ > ----------------------------------------------------------- > > (Updated apr 21, 2017, 8:04 a.m.) > > > Review request for Plasma. > > > Repository: plasma-integration > > > Description > ------- > > Implement QPlatformTheme::fileIconPixmap() to make QFileIconProvider work. > > > Diffs > ----- > > src/platformtheme/kdeplatformtheme.h 7835439 > src/platformtheme/kdeplatformtheme.cpp 704f176 > > Diff: https://git.reviewboard.kde.org/r/130094/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Eugene Shalygin > >
