davidedmundson added a comment.
Cool, seems like a solid approach. Just nitpicks left. INLINE COMMENTS > mousehelper.h:41-42 > + > + Q_INVOKABLE QPointF globalMousePosition() const; > + Q_INVOKABLE void setGlobalMousePosition(const QPointF &pos); > +}; You don't need these to be invokable if you're exposing them as a property. Right now you're exporting two things with the same name, the value of a property and a function. > qmlplugins.cpp:41 > qmlRegisterType<Milou::DragHelper> (uri, 0, 2, "DragHelper"); > + qmlRegisterType<Milou::MouseHelper> (uri, 0, 1, "MouseHelper"); > } May as well register a singleton, it doesn't have a state. Instead of having one object created per delegate, we just one have object. REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D5490 To: leszeklesner, broulik Cc: ltoscano, qi437103, lfurmetz, anthonyfieroni, davidedmundson, plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
