drosca added inline comments.

INLINE COMMENTS

> sebas wrote in ListItemBase.qml:282
> Should be "volume", since that's the property. Or perhaps we don't need 
> "volume" or "Volume".

"Volume" is a role from the model, so assigning to the "volume" property 
instead only makes it go through one indirection level. The "volume" property 
should be made readonly as it is there only for property changes.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  auto-raise-volume (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D5695

To: drosca, #plasma, sebas
Cc: sebas, Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, apol, lukas

Reply via email to