davidedmundson added a comment.
In my opinion, and the impression you gave me when we talked about the design. We shouldn't have Night mode stuff in kwin. We should have generic colour correction in kwin (albeit with fading happening in kwin to reduce traffic) I guess this changed mid way? I can see your class names start with "color correction" and then you have virtual "supportsNightMode" which is very specific. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5928 To: subdiff, #kwin Cc: davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
