tcberner added a comment.
I want to look at this some more this weekend. INLINE COMMENTS > adridg wrote in kcheckpass.c:77 > Possibly add > > #if !(HAVE_SIGNALFD_H_ || HAVE_EVENT_H) > #error > #endif > > to double-check that it's one or the other (reflecting the check in CMake) That should not be necessary, as cmake will fail if neither is present. > adridg wrote in kcheckpass.c:470 > Here, and in the code for SIGUSR1, the check for sending process is missing > -- doesn't kevent support that? (Doesn't look like it) Yes, I'm aware of its absence, however, I could not yet find out how to get that data. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5825 To: tcberner, #freebsd, graesslin Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
