leinir created this revision. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY This code removes the custom pagination in KNSBackend in favour of using the internal pagination in KNSCore::Engine. It further removes the explicit call to request data, as this is already done by setting the search term, which caused duplicated results to be returned. Further, remove results already returned when KNS requests the view to be cleared, further reducing duplicate view entries. nb: The fact setting the search term starts a new search is undocumented, which will need fixing (some thorough documentation work is ongoing in kns as part of a gsoc project) TEST PLAN Start Discover without patch, notice duplicates for most KNS sources Start discover with patch, notice no duplicate entries for KNS sources REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D6191 AFFECTED FILES libdiscover/backends/KNSBackend/KNSBackend.cpp libdiscover/backends/KNSBackend/KNSBackend.h To: leinir, apol, #discover_software_store Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
