cfeck added inline comments.

INLINE COMMENTS

> cfeck wrote in kiconloader.cpp:863
> Please use some rounding here. Scaling factors such as 1.4 cannot be 
> represented exactly.
> 
> Either add some formatting specifiers, e.g. for three decimal places, or use 
> qRound(scale * 1000).

Just checked that the default precision is 6 digits, so maybe not that 
important.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: cfeck, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

Reply via email to