broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This re-introduces the ability to automatically speak out loud the current 
time in intervals configured by the user (between every minute and every hour). 
It uses QtTextToSpeech module when available.

TEST PLAN
  Even if I installed `libqt5texttospeech5` on neon I did not get working 
speech synthesis as it was missing the speechd plugin (Bug 381523)
  
  Because of QLocale limitations I had to go great lengths to figure out 
whether I should be announcing in 24 hour format or 12 with "am/pm".
  
  Verified that switching 12/24 in digital clock still worked (both checkbox 
and `LANG` variable) and also that it affects the voice in the same way. Gives 
you a "It is eleven twenty-nine aaaammm" robot voice of doom. We don't have any 
configuration utility in System Settings for voice yet, right?
  
  Also verified that when QtTextToSpeech is not installed, this feature gets 
completely disabled including the config option that will be hidden.
  
  Settings dialog with combo box and a speaker icon to test the voice.
  F3792915: Screenshot_20170622_145632.png 
<https://phabricator.kde.org/F3792915>

REVISION DETAIL
  https://phabricator.kde.org/D6386

AFFECTED FILES
  applets/digital-clock/package/contents/config/main.xml
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/configAppearance.qml
  applets/digital-clock/plugin/CMakeLists.txt
  applets/digital-clock/plugin/digitalclockplugin.cpp
  applets/digital-clock/plugin/texttospeech.cpp
  applets/digital-clock/plugin/texttospeech.h

To: broulik, #plasma, #vdg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

Reply via email to