davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > egl_context_attribute_builder.cpp:50 > + if (isRobust()) { > + attribs.emplace_back(EGL_CONTEXT_OPENGL_ROBUST_ACCESS_EXT); > + attribs.emplace_back(EGL_TRUE); Do you have some sort of checklist of C++11 features to use? For a single integer, emplace_back is going to do the exact same thing as the standard push_back. REPOSITORY R108 KWin BRANCH context-attribute-builder REVISION DETAIL https://phabricator.kde.org/D6396 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas