lukas added inline comments. INLINE COMMENTS
> ltoscano wrote in autostart.cpp:75 > Should this be "Session" or "Plasma Session"? Aren't the settings changed > here valid for all desktops which follow the XDG spec? Yes, it should be valid for all DEs (I'd vote for "Session" only then) > emailclientconfig_ui.ui:12 > <property name="whatsThis"> > - <string>Kmail is the standard Mail program for the KDE > desktop.</string> > + <string>Kmail is the standard Mail program for the Plasma > desktop.</string> > </property> I'd keep the old one as well, just for a better discoverability > ltoscano wrote in globalpaths.cpp:127 > I explicitly wrote "Plasma" because this setting seems to be Plasma-specific. > Did I understand it correctly? Again, this should be desktop agnostic REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
