hpereiradacosta accepted this revision. hpereiradacosta added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > broulik wrote in breezestyle.cpp:3082 > From what I can tell the difference is negligible. `qobject_cast` goes > through `QMetaObject::cast` which then calls `inherits` internally, so I'd > say `inherits` is the better choice. > > I didn't benchmark, though. I just followed what the rest of the code around > it was doing (`inherits`) Code uses both actually (usually qobject_cast for "public" classes, from Qt, and inherits for "private" classes, or kde). In any case, I trust your investigation :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D6544 To: broulik, #plasma, hpereiradacosta, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
