anthonyfieroni added inline comments.

INLINE COMMENTS

> fvogt wrote in client.cpp:1428
> Why not directly `QString::fromUtf8(reply.name, reply.name_len)` here? It 
> would save one unnecessary copy. Alternatively, 
> `QByteArray::fromRawData(reply.name, reply.name_len)`, but that's more 
> verbose.

QByteArray has a move constructor, it's not copy.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7046

To: graesslin, #kwin, #plasma
Cc: anthonyfieroni, fvogt, broulik, plasma-devel, kwin, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

Reply via email to