davidedmundson added a comment.
I'm not particularly convinced. You watch a movie, you get some notifications, but ignore them. You move the mouse, you get told now completely out-of-date info. Also any notification created by KNotification with actions simply won't work. The client side stops listening for replies after 30 seconds. Two things definitely need fixing: - with this, and your other patch - you'll get history twice, worse as your history shows a timestamp. - persistent notifications should definitely not be re-emitted as the original will still be there. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7256 To: progwolff, #plasma, mart Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
