graesslin added a comment.
In https://phabricator.kde.org/D7359#136845, @davidedmundson wrote: > In https://phabricator.kde.org/D7359#136559, @graesslin wrote: > > > I'm wondering whether we should do it directly in Toplevel as we also have the XWayland windows which have a Surface. > > > I don't think XWayland windows can really make use of this. X windows know the screen sizes and their own location, so it doesn't really map to anything. > A quick grep of xwayland confirmed there wasn't even a wl_surface_add_listener anywhere. Point taken. My thinking was that XWayland might do something clever with it like scale up windows internally (send the windows a wrong geometry), but I guess that's just unreasonable wishful thinking. So good to go in ShellClient, if in a distant future XWayland becomes a valid target, we can move the code anyway. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7359 To: davidedmundson, #plasma Cc: johanhelsing, graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas
