davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> blur.cpp:76
>      connect(effects, SIGNAL(screenGeometryChanged(QSize)), this, 
> SLOT(slotScreenGeometryChanged()));
> +    connect(effects, &EffectsHandler::xcbConnectionChanged, this,
> +        [this] {

I was expecting you to do what you for the present windows effect with calling 
your local lambda announceSupportProperties.

IMHO it's neater than duplicating - but this is fine too.

REPOSITORY
  R108 KWin

BRANCH
  effects-xcb-connection-changed

REVISION DETAIL
  https://phabricator.kde.org/D7761

To: graesslin, #kwin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to