apol added inline comments. INLINE COMMENTS
> davidedmundson wrote in kaccess.cpp:722 > we've effectively removed this connect to dialogClosed. Now closing goes to > noClicked. > > Is this a problem? I noticed. I'm not sure to be honest. My thinking is that the user shouldn't notice the difference between saying "No" and closing the window. I can short-circuit the QDialogButtonBox::rejected if that makes you feel more comfortable with the patch. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8115 To: apol, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
