davidedmundson added a comment.
Is 5.39 tagged already?
INLINE COMMENTS
> plasmadesktoptheme.cpp:48
> + this, [this]() {
> + if (m_parentItem && m_parentItem->window()) {
> + connect(m_parentItem->window(),
> &QWindow::activeChanged,
and disconnect from the old window
> plasmadesktoptheme.cpp:82
> +
> + KIconLoader::global()->setCustomPalette(pal);
> +
This is bad
If some other place miles away in a random lib in a different place in the UI,
sets a colour, it will be wrong.
Why meddle with the global loader if you're passing it as an arg anyway?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D7941
To: mart, #plasma, #kirigami, hein
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, hein
