graesslin added inline comments. INLINE COMMENTS
> davidedmundson wrote in aurorae.cpp:354 > Changing the rendering doesn't block making calls to any of the openGL calls > in QtBase. > The only changes are purely inside QtQuick > > So: > creating a context still works fine > creating an FBO still works fine > > why m_view->setRenderTarget and m_view->resetOpenGLState still work are the > more interesting questions > but that's because they're virtual methods that no-op. > > With this code: > we create an OpenGL context > set it to be active > then ignore it and do something completely different with QPainter instead then I would suggest to guard it to only do it in the OpenGL case. Especially on Wayland without OpenGL support this could be very nasty. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8039 To: davidedmundson, #plasma Cc: graesslin, apol, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
