davidedmundson added a comment.
Trace is different, so ...progress! I don't think there's anything specifically wrong with this patch in itself. I'll fix that and review the rest of this class. Sorry, Thanks for the quick feedback. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8321 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart