davidedmundson added inline comments.

INLINE COMMENTS

> FindXorgLibinput.cmake:8
> +#
> +# Copyright (c) 2015 David Edmundson <davidedmund...@kde.org>
> +#

that's not your name...

> CMakeLists.txt:58
>  
> -if (SYNAPTICS_FOUND AND X11_Xinput_FOUND)
> +if (SYNAPTICS_FOUND AND XORGLIBINPUT_FOUND AND X11_Xinput_FOUND)
>      add_subdirectory(touchpad)

do you mean "AND"  especially given this is optional?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8168

To: xuetianweng, davidedmundson, mart
Cc: ngraham, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

Reply via email to