broulik added inline comments. INLINE COMMENTS
> Button.qml:43 > + //in case of explicit & the button manages it by itself > + enabled: controlRoot.text.indexOf("&") == -1 > + sequence: controlRoot.Kirigami.MnemonicData.sequence How does it behave if text contains an `&&` ie. user explicitly wants an ampersand but not a mnemonic? > kquickstyleitem.cpp:1634 > + } > + } else { > + if (event->type() == QEvent::KeyPress) { Check `watched == m_window`? > kquickstyleitem.cpp:1635 > + } else { > + if (event->type() == QEvent::KeyPress) { > + QKeyEvent *ke = static_cast<QKeyEvent *>(event); You could just check `KeyPress || KeyRelease` since you're doing the same thing in both branches REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D8827 To: mart, #plasma Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart