davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I think we need some big discussion about how powerdevil inhbitions, logind 
inhibitions and this are all going to fit together in a clear coherent way.
  
  But given there are clients using this protocol already, I guess we need this 
regardless certainly at a protocol level.

INLINE COMMENTS

> idleinhibit_interface_v1.cpp:73
> +    if (!s) {
> +        // send error?
> +        return;

I think it should

REPOSITORY
  R127 KWayland

BRANCH
  idle-inhibit-manager

REVISION DETAIL
  https://phabricator.kde.org/D8396

To: graesslin, #frameworks, #kwin, #plasma_on_wayland, davidedmundson
Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

Reply via email to