broulik created this revision.
broulik added reviewers: Plasma, VDG, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Implements proper keyboard navigation (up/down) as well as space to goggle 
check box
  - Makes list sortable by name, comment, and "checked" (so you easily get an 
overview of types you enabled)
  - Add mime type "comment" which is more user-friendly

TEST PLAN
  - The checkbox becomes hardly visible on a selected row. In QWidgets Breeze 
has a hack to paint in white in this case but it cannot be done int QQC :/
  - Tested keyboard up and down as well as space to toggle
  - Sorting and filtering (the filter still only searches the name, not the 
comment) doesn't seem to confuse the table view or model
  
  F5494272: Screenshot_20171116_163712.png 
<https://phabricator.kde.org/F5494272>

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8849

AFFECTED FILES
  containments/desktop/package/contents/ui/ConfigFilter.qml
  containments/desktop/plugins/folder/mimetypesmodel.cpp

To: broulik, #plasma, #vdg, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to