mart added inline comments.

INLINE COMMENTS

> hein wrote in main.qml:175
> This and similar bindings will break when the user changes the spinbox value, 
> so after a manual adjustment e.g. defaults() won't work any longer. It needs 
> a seperate Connections à la https://phabricator.kde.org/D8911.

no, it doesn't seem to break. when the change in value is donefrom the c++ 
side, which is the case of a qqc2 spinbox (as opposed to qqc1) the bindings 
actually stay in place, would break only if from javascript side a 
spinbox.value=foo was executed

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8916

To: mart, #plasma, #vdg
Cc: hein, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to