anthonyfieroni added inline comments.
INLINE COMMENTS
> main.qml:30-39
> + function applyBusyCursorCurrentIndex() {
> + if (kcm.busyCursorCurrentIndex == 0) {
> + busyCursorDisabled.checked = true;
> + } else if (kcm.busyCursorCurrentIndex == 1) {
> + busyCursorStatic.checked = true;
> + } else if (kcm.busyCursorCurrentIndex == 2) {
> + busyCursorBlinking.checked = true;
My personal note is not mandatory but this piece of code can be seen 2 times in
C++ part and 1 in QML. Can we add it on C++ part and called here too.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8911
To: hein, #plasma, mart, abetts
Cc: anthonyfieroni, mmustac, ngraham, davidedmundson, broulik, plasma-devel,
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, mart
