broulik created this revision. broulik added reviewers: Plasma, VDG, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY Qt internally uses `QIcon::Selected` for when the action button in a line edit is pressed. We use that state for selected menu items rendering the icon inverted. This means that in line edits the icon becomes invisible (white on white) when the button is pressed. I adapted the code and intercept its paint event to use `QIcon::Active` instead which makes the icon visible. TEST PLAN Clear button in text fields stays visible and glows while pressed rather than becoming invisible. Not pressed F5531106: Screenshot_20171206_161516.png <https://phabricator.kde.org/F5531106> Before pressed F5531105: Screenshot_20171206_161455.png <https://phabricator.kde.org/F5531105> After pressed F5531107: Screenshot_20171206_161539.png <https://phabricator.kde.org/F5531107> REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9227 AFFECTED FILES kstyle/breezestyle.cpp kstyle/breezestyle.h To: broulik, #plasma, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
