davidedmundson added inline comments.

INLINE COMMENTS

> comicupdater.cpp:56
> +    } else {
> +        mUpdateIntervall = 3;
>      }

wouldn't you still need to call checkForUpdate() if you went into this path?

Especially as checkForUpdate is the one that sets up the timer to call itself 
again

> comicupdater.cpp:86
>      if ( !mLastUpdate.isValid() || ( mLastUpdate.addDays( mUpdateIntervall ) 
> < QDateTime::currentDateTime() ) ) {
> -        mGroup.writeEntry( "lastUpdate", QDateTime::currentDateTime() );
> +        mLastUpdate = QDateTime::currentDateTime();
> +        mGroup.writeEntry( "lastUpdate", mLastUpdate );

I assume this line is the important change?

+1 to this bit.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D9338

To: anthonyfieroni, davidedmundson, broulik, #plasma, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to