fvogt added a comment.
Looks good to me, but I wonder whether > KWallet writes an error to stderr when a 0-winId is given to openWallet() which is received by git-lfs and aborts the operation. should be fixed more in a more general way as well. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9072 To: mkoller, cfeck, jriddell, whiting Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart