lepagevalleeemmanuel added a comment.
I tried the patch on my CI and it compiled and linked. I also reviewed the changes between my patchset and this diff and approve the change, I also agree with Apol about the `target_link_libraries` issue. It should be mutualized between the `if` and `else`. So "almost ship it!" REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9892 To: mart, #kirigami, lepagevalleeemmanuel Cc: apol, plasma-devel, davidedmundson, mart, hein