apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > ApplicationPage.qml:157 > text: appInfo.application.name > + lineHeight: 1.0 > maximumLineCount: 1 That's the default, no need to insist on it. > ApplicationPage.qml:167 > + maximumLineCount: 2 > + lineHeight: lineCount > 1 ? 0.75 : 1.2 > elide: Text.ElideRight Is it really necessary? I wouldn't change the default at least to 1.2, leave 1.0 as it's the level 4 font. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10023 To: ngraham, apol, #discover_software_store, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
