davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
For context, krunner inherits from Dialog.
Dialog does all this stuff. Duplicating it here is wrong.
Must have been ported first or something.
INLINE COMMENTS
> view.cpp:194-200
> bool setState = event->type() == QEvent::Show;
> if (event->type() == QEvent::PlatformSurface) {
> setState =
> (static_cast<QPlatformSurfaceEvent*>(event)->surfaceEventType() ==
> QPlatformSurfaceEvent::SurfaceCreated);
> }
> if (setState) {
> KWindowSystem::setState(winId(), NET::SkipTaskbar | NET::SkipPager);
> }
This relates to the QXcbWindow comment that you removed, can you leave it.
(I /think/ you can remove this code, it relates to David Rosca's patch that
landed ages ago. Check first though)
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10197
To: apol, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
